linux-kernel - Re: [PATCH 0/2] KVM: SVM: move the SEV command handling into a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82b462cf-6e94-0e59-2b98-01cc5acd6ede@amd.com>
Date:   Mon, 4 Feb 2019 17:17:57 +0000
From:   "Singh, Brijesh" <brijesh.singh@....com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
CC:     "Singh, Brijesh" <brijesh.singh@....com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>, Borislav Petkov <bp@...en8.de>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Joerg Roedel <joro@...tes.org>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>
Subject: Re: [PATCH 0/2] KVM: SVM: move the SEV command handling into a
 separate file



On 2/1/19 12:20 PM, Sean Christopherson wrote:
> On Fri, Feb 01, 2019 at 04:47:12PM +0000, Singh, Brijesh wrote:
>> svm.c is pretty huge, before we add more SEV specific commands (e.g SEV-ES,
>> SEV-Migration etc) lets move the SEV command handling into a separate file.
>> There is no logical changes in this series.
> 
> Any reason not to create arch/x86/kvm/svm/ before introducing sev.c?
> 

There are several features in svm.c that can be moved to different
files, SEV bits are just the start. I was thinking that we create
svm directory after features are separated in different files rather
than creating the directory first. Having said so, I am not oppose
to creating directory first then moving the code in a separate file.

Paolo, Radim

thoughts ?

thanks