linux-kernel - Re: [PATCH v4 02/16] block: sed-opal: use correct macro for method length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190204144323.GB31132@infradead.org>
Date:   Mon, 4 Feb 2019 06:43:23 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     David Kozub <zub@...ux.fjfi.cvut.cz>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Jonathan Derrick <jonathan.derrick@...el.com>,
        Scott Bauer <sbauer@...donthack.me>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
Subject: Re: [PATCH v4 02/16] block: sed-opal: use correct macro for method
 length

On Fri, Feb 01, 2019 at 09:50:09PM +0100, David Kozub wrote:
> From: Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
> 
> Also the values of OPAL_UID_LENGTH and OPAL_METHOD_LENGTH are the same,
> it is weird to use OPAL_UID_LENGTH for the definition of the methods.
> 
> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
> Reviewed-by: Scott Bauer <sbauer@...donthack.me>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>

Dave, when you resubmit other peoples patches you should also add
your Signed-off-by: line to the end of the signoff chain.