linux-kernel - RE: [PATCH 5/5] EDAC, mce_amd: Print ExtErrorCode and description on a single line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN7PR12MB2593CF4ABBC4ECFCDE87FC7AF86D0@BN7PR12MB2593.namprd12.prod.outlook.com>
Date:   Mon, 4 Feb 2019 15:14:27 +0000
From:   "Ghannam, Yazen" <Yazen.Ghannam@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bp@...e.de" <bp@...e.de>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: RE: [PATCH 5/5] EDAC, mce_amd: Print ExtErrorCode and description on
 a single line

> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: Sunday, February 3, 2019 6:22 AM
> To: Ghannam, Yazen <Yazen.Ghannam@....com>
> Cc: linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org; bp@...e.de;
> tony.luck@...el.com; x86@...nel.org
> Subject: Re: [PATCH 5/5] EDAC, mce_amd: Print ExtErrorCode and description
> on a single line
> 
> On Fri, Feb 01, 2019 at 10:55:54PM +0000, Ghannam, Yazen wrote:
> > From: Yazen Ghannam <yazen.ghannam@....com>
> >
> > Save a log line by printing the extended error code and the description
> > on a single line. This is similar to how errors are printed in other
> > subsystems, e.g. "#, description". If we don't have a valid description
> > then only the number/code is printed.
> >
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> > ---
> >  drivers/edac/mce_amd.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
> > index 7e29ceabdf6f..f286b880f981 100644
> > --- a/drivers/edac/mce_amd.c
> > +++ b/drivers/edac/mce_amd.c
> > @@ -965,13 +965,12 @@ static void decode_smca_error(struct mce *m)
> >
> >  	ip_name = smca_get_long_name(bank_type);
> >
> > -	pr_emerg(HW_ERR "%s Extended Error Code: %d\n", ip_name, xec);
> > +	pr_emerg(HW_ERR "%s Ext. Error Code: %d", ip_name, xec);
> >
> >  	/* Only print the decode of valid error codes */
> >  	if (xec < smca_mce_descs[bank_type].num_descs &&
> >  			(hwid->xec_bitmap & BIT_ULL(xec))) {
> > -		pr_emerg(HW_ERR "%s Error: ", ip_name);
> > -		pr_cont("%s.\n", smca_mce_descs[bank_type].descs[xec]);
> > +		pr_cont(", %s.\n", smca_mce_descs[bank_type].descs[xec]);
> 
> If the if-condition doesn't hit, we never print the \n
> 

Yes, you're right. But it seems that the next pr_* that's not a pr_cont will be on
a newline automatically.

Should I add an explicit newline just to be sure we get one?

Thanks,
Yazen