linux-kernel - Re: [PATCH v7 13/15] KVM: s390: add gib_alert_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <50f05038-f414-50f5-dbe7-e2bcca0b8433@linux.ibm.com>
Date:   Tue, 5 Feb 2019 12:38:28 +0100
From:   Pierre Morel <pmorel@...ux.ibm.com>
To:     Michael Mueller <mimu@...ux.ibm.com>,
        KVM Mailing List <kvm@...r.kernel.org>
Cc:     Linux-S390 Mailing List <linux-s390@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH v7 13/15] KVM: s390: add gib_alert_irq_handler()

On 31/01/2019 09:52, Michael Mueller wrote:
> The patch implements a handler for GIB alert interruptions
> on the host. Its task is to alert guests that interrupts are
> pending for them.
> 
> A GIB alert interrupt statistic counter is added as well:
> 
> $ cat /proc/interrupts
>            CPU0       CPU1
>    ...
>    GAL:      23         37   [I/O] GIB Alert
>    ...
> 
> Signed-off-by: Michael Mueller <mimu@...ux.ibm.com>
> Acked-by: Halil Pasic <pasic@...ux.ibm.com>
> ---

The only thing that bother me is the short timer's expiration value.
But it is optimization and it is working for me so.

Reviewed-by: Pierre Morel<pmorel@...ux.ibm.com>


-- 
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany