linux-kernel - Re: [PATCH] device: Fix comment for driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190205132339.GW9224@smile.fi.intel.com>
Date:   Tue, 5 Feb 2019 15:23:39 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     David Engraf <david.engraf@...go.com>
Cc:     gregkh@...uxfoundation.org, rafael.j.wysocki@...el.com,
        hdegoede@...hat.com, aspriel@...il.com, brgl@...ev.pl,
        heikki.krogerus@...ux.intel.com, vivek.gautam@...eaurora.org,
        joe@...ches.com, jroedel@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] device: Fix comment for driver_data in struct device

On Tue, Feb 05, 2019 at 01:19:52PM +0100, David Engraf wrote:
> dev_set_drvdata/dev_get_drvdata is used to access driver_data
> in struct device.

The original comment might be slight confusing, though we all know the concept
of getters and setters.

>  	void		*platform_data;	/* Platform specific data, device
>  					   core doesn't touch it */
>  	void		*driver_data;	/* Driver data, set and get with
> -					   dev_set/get_drvdata */
> +					   dev_set_drvdata/dev_get_drvdata */
>  	struct dev_links_info	links;
>  	struct dev_pm_info	power;
>  	struct dev_pm_domain	*pm_domain;
> -- 
> 2.17.1
> 

-- 
With Best Regards,
Andy Shevchenko