linux-kernel - Re: [PATCH] device: Fix comment for driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75fac672-f1f2-5b15-d871-308469943eb9@sysgo.com>
Date:   Wed, 6 Feb 2019 08:49:08 +0100
From:   David Engraf <david.engraf@...go.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     gregkh@...uxfoundation.org, rafael.j.wysocki@...el.com,
        hdegoede@...hat.com, aspriel@...il.com, brgl@...ev.pl,
        heikki.krogerus@...ux.intel.com, vivek.gautam@...eaurora.org,
        joe@...ches.com, jroedel@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] device: Fix comment for driver_data in struct device

On 05.02.19 at 14:23, Andy Shevchenko wrote:
> On Tue, Feb 05, 2019 at 01:19:52PM +0100, David Engraf wrote:
>> dev_set_drvdata/dev_get_drvdata is used to access driver_data
>> in struct device.
> 
> The original comment might be slight confusing, though we all know the concept
> of getters and setters.

Okay you're right. I was a bit confused about the syntax.

Thanks
- David


>>   	void		*platform_data;	/* Platform specific data, device
>>   					   core doesn't touch it */
>>   	void		*driver_data;	/* Driver data, set and get with
>> -					   dev_set/get_drvdata */
>> +					   dev_set_drvdata/dev_get_drvdata */
>>   	struct dev_links_info	links;
>>   	struct dev_pm_info	power;
>>   	struct dev_pm_domain	*pm_domain;
>> -- 
>> 2.17.1
>>
>