linux-kernel - Re: perf: python3 + tests attr.py failing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190205132846.GO5593@kernel.org>
Date:   Tue, 5 Feb 2019 10:28:46 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Tony Jones <tonyj@...e.de>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        Seeteena Thoufeek <s1seetee@...ux.vnet.ibm.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: perf: python3 + tests attr.py failing

Em Tue, Feb 05, 2019 at 10:08:43AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Feb 05, 2019 at 10:02:14AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Feb 04, 2019 at 09:37:38PM +0100, Jiri Olsa escreveu:
> > > On Mon, Feb 04, 2019 at 12:10:42PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Noticed this now when building with PYTHON=python3, can you take a look?
> > > > For now I'm reinstalling python2-devel and building with it, i.e.
> > > > removing that PYTHON=python3 make command line variable.
> > > which Fedora are you on 29? I'm on 28
>  
> > [acme@...co ~]$ cat /etc/fedora-release 
> > Fedora release 29 (Twenty Nine)
>  
> > [acme@...co tumbleweed]$ rpm -qa | grep python3 | wc -l
> > 96
> > [acme@...co tumbleweed]$ rpm -q python3-devel
> > python3-devel-3.7.2-4.fc29.x86_64
> > [acme@...co tumbleweed]$ 
> > 
> > But it is a SyntaxError, so something simpler, looking up...
> 
> So python 3 needs to have that as:
> 
> 	except Unsup as obj:
> 
> How to make this work with both is what I'm trying to figure out now...

So, all this is fixed in perf/core already by:

commit 35ea7e4bbb89ecd32057f5f6a2a8feb0d7224e51
Author: Tony Jones <tonyj@...e.de>
Date:   Wed Jan 23 16:52:29 2019 -0800

    perf script python: Add Python3 support to tests/attr.py
    
    Support both Python 2 and Python 3 in tests/attr.py
    
    The use of "except as" syntax implies the minimum supported Python2 version is
    now v2.6

 ------------------

 So nevermind, sorry for the noise :-)

- Arnaldo