linux-kernel - Re: perf: python3 + tests attr.py failing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Feb 2019 10:49:35 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Tony Jones <tonyj@...e.de>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        Seeteena Thoufeek <s1seetee@...ux.vnet.ibm.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: perf: python3 + tests attr.py failing

Em Mon, Feb 04, 2019 at 09:37:38PM +0100, Jiri Olsa escreveu:
> On Mon, Feb 04, 2019 at 12:10:42PM -0300, Arnaldo Carvalho de Melo wrote:
> > Noticed this now when building with PYTHON=python3, can you take a look?
> > For now I'm reinstalling python2-devel and building with it, i.e.
> > removing that PYTHON=python3 make command line variable.
> > 
> > [root@...co ~]# perf test -v perf_event_attr
> > 16: Setup struct perf_event_attr                          :
> > --- start ---
> > test child forked, pid 23937
> >   File "/home/acme/libexec/perf-core/tests/attr.py", line 325
> >     except Unsup, obj:
> >                 ^
> > SyntaxError: invalid syntax
> > test child finished with -1
> > ---- end ----
> > Setup struct perf_event_attr: FAILED!
> 
> hum, I built the same way like you 'make PYTHON=python3'
> [root@...va perf]# ldd ./perf | grep python
>         libpython3.6m.so.1.0 => /lib64/libpython3.6m.so.1.0 (0x00007f4ca7cc4000)
> 
> and get 'Ok result'
> 
> [root@...va perf]# ./perf test attr
> 16: Setup struct perf_event_attr                          : Ok
> 48: Synthesize attr update                                : Ok
> 
> 
> [root@...va perf]# python3 --version
> Python 3.6.8
> [root@...va perf]# rpm -qa | grep python3-devel
> python3-devel-3.6.8-1.fc28.x86_64
> 
> which Fedora are you on 29? I'm on 28

I think you tested perf/core, that has Tony's fix to make 'perf test perf_event_attr'
work with both python2 and python3, right?

While I was having that failure with perf/urgent.

I just cherry-picked:

commit 35ea7e4bbb89ecd32057f5f6a2a8feb0d7224e51
Author: Tony Jones <tonyj@...e.de>
Date:   Wed Jan 23 16:52:29 2019 -0800

    perf script python: Add Python3 support to tests/attr.py


----------------------

And now my perf/urgent branch passes that 'perf test' entry with both
python2 and 3.

- Arnaldo