linux-kernel - Re: [PATCH v7 05/10] clk: bd718x7: Support ROHM BD70528 clk block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154947428734.74891.4523492147164733315@swboyd.mtv.corp.google.com>
Date:   Wed, 06 Feb 2019 09:31:27 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        mazziesaccount@...il.com
Cc:     Guenter Roeck <linux@...ck-us.net>,
        heikki.haikola@...rohmeurope.com, mikko.mutanen@...rohmeurope.com,
        lee.jones@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
        broonie@...nel.org, gregkh@...uxfoundation.org, rafael@...nel.org,
        mturquette@...libre.com, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, sre@...nel.org, lgirdwood@...il.com,
        a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        wim@...ux-watchdog.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v7 05/10] clk: bd718x7: Support ROHM BD70528 clk block

Quoting Matti Vaittinen (2019-02-06 01:39:38)
> @@ -86,9 +87,21 @@ static int bd71837_clk_probe(struct platform_device *pdev)
>                 dev_err(&pdev->dev, "No parent clk found\n");
>                 return -EINVAL;
>         }
> -
> -       c->reg = BD718XX_REG_OUT32K;
> -       c->mask = BD718XX_OUT32K_EN;
> +       switch (mfd->chip_type) {
> +       case ROHM_CHIP_TYPE_BD71837:
> +       case ROHM_CHIP_TYPE_BD71847:
> +

Nitpick: why the extra newline above?

> +               c->reg = BD718XX_REG_OUT32K;
> +               c->mask = BD718XX_OUT32K_EN;
> +               break;
> +       case ROHM_CHIP_TYPE_BD70528:
> +               c->reg = BD70528_REG_CLK_OUT;
> +               c->mask = BD70528_CLK_OUT_EN_MASK;
> +               break;
> +       default:
> +               dev_err(&pdev->dev, "Unknown clk chip\n");
> +               return -EINVAL;
> +       }
>         c->mfd = mfd;
>         c->pdev = pdev;
>         c->hw.init = &init;