linux-kernel - Re: [PATCH 1/2] mtd: spi-nor: Add support for EN25Q80A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52338dfe-aca1-503d-6871-c4be09f1f3ac@kontron.de>
Date:   Thu, 7 Feb 2019 10:06:56 +0000
From:   Schrempf Frieder <frieder.schrempf@...tron.de>
To:     "Tudor.Ambarus@...rochip.com" <Tudor.Ambarus@...rochip.com>,
        "marek.vasut@...il.com" <marek.vasut@...il.com>
CC:     "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "bbrezillon@...nel.org" <bbrezillon@...nel.org>,
        "richard@....at" <richard@....at>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mtd: spi-nor: Add support for EN25Q80A

Hi Tudor,

On 03.02.19 14:33, Tudor.Ambarus@...rochip.com wrote:
> Hi, Frieder,
> 
> On 01/23/2019 09:56 AM, Schrempf Frieder wrote:
>> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>>
>> This adds support for the EON EN25Q80A, a 8Mb SPI NOR chip.
> 
> I would suggest to specify who is using this flash and how did you test it. This
> way we will not end up with support for flashes that are not actually used.

Ok. The flash is used by a board that I plan to upstream. Maybe I should 
just resubmit this together with the actual board support patches?

Likewise for my other patch (MX25V8035F), this is for another board I 
plan to upstream soon.

> 
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
>> ---
>>   drivers/mtd/spi-nor/spi-nor.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index 6e13bbd1aaa5..aa8a04293a25 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -1737,6 +1737,8 @@ static const struct flash_info spi_nor_ids[] = {
>>   	/* EON -- en25xxx */
>>   	{ "en25f32",    INFO(0x1c3116, 0, 64 * 1024,   64, SECT_4K) },
>>   	{ "en25p32",    INFO(0x1c2016, 0, 64 * 1024,   64, 0) },
>> +	{ "en25q80a",   INFO(0x1c3014, 0, 64 * 1024,   16,
>> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> 
> I'm reading EN25Q80A Rev. H, Issue Date: 2012/10/23
>   datasheet. I don't see the bfpt table described, so probably it doesn't support
> it. The flash advertises SPINOR_OP_READ_1_4_4 (0xeb), but not
> SPINOR_OP_READ_1_1_4 (0x6b). In spi_nor_init_params(), when SPI_NOR_QUAD_READ is
> set, we assume that SNOR_HWCAPS_READ_1_1_4 is supported, so we will use 0x6b for
> quad reads. I can't see how the flash works with 0x6b, unless there is a bfpt
> table that indicates support for 0xebh.
> 
> If it does support bfpt, set just SECT_4K | SPI_NOR_DUAL_READ, the latter will
> trigger the bfpt parsing.

Thanks for explaining this. I missed the point, that SPI_NOR_QUAD_READ 
actually requires support for SPINOR_OP_READ_1_1_4.

> 
> If you will resubmit, please order the entry in alphabetical order, by name.

Ok.

Thanks,
Frieder