Message-ID: <c872f03c-714a-d99f-d555-e897f80d67be@gmail.com>
Date:   Thu, 7 Feb 2019 16:08:09 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Erin Lo <erin.lo@...iatek.com>, Rob Herring <robh@...nel.org>
Cc:     Mark Rutland <mark.rutland@....com>, Ben Ho <Ben.Ho@...iatek.com>,
        Mars Cheng <mars.cheng@...iatek.com>,
        Mengqi Zhang <Mengqi.Zhang@...iatek.com>,
        linux-clk <linux-clk@...r.kernel.org>,
        Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>,
        Weiyi Lu <weiyi.lu@...iatek.com>,
        Marc Zyngier <marc.zyngier@....com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Yingjoe Chen <yingjoe.chen@...iatek.com>,
        devicetree@...r.kernel.org, Jason Cooper <jason@...edaemon.net>,
        Seiya Wang <seiya.wang@...iatek.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Eddie Huang <eddie.huang@...iatek.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        srv_heupstream <srv_heupstream@...iatek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        linux-kernel@...r.kernel.org,
        Zhiyong Tao <Zhiyong.Tao@...iatek.com>
Subject: Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation
 board dts and Makefile



On 01/02/2019 06:11, Erin Lo wrote:
> Add back more people since mail server issue
> 
> On Fri, 2019-02-01 at 11:33 +0800, Erin Lo wrote:
>> On Thu, 2019-01-31 at 15:10 -0600, Rob Herring wrote:
>>> On Wed, Jan 30, 2019 at 8:34 PM Erin Lo <erin.lo@...iatek.com> wrote:
>>>>
>>>> On Wed, 2019-01-30 at 10:22 -0600, Rob Herring wrote:
>>>>> On Thu, Jan 24, 2019 at 04:07:20PM +0800, Erin Lo wrote:
>>>>>> From: Ben Ho <Ben.Ho@...iatek.com>
>>>>>>
>>>>>> Add basic chip support for Mediatek 8183, include
>>>>>> pinctrl file, uart node with correct uart clocks, pwrap device
>>>>>>
>>>>>> Add clock controller nodes, include topckgen, infracfg,
>>>>>> apmixedsys and subsystem.
>>>>>>
>>>>>> Signed-off-by: Ben Ho <Ben.Ho@...iatek.com>
>>>>>> Signed-off-by: Erin Lo <erin.lo@...iatek.com>
>>>>>> Signed-off-by: Seiya Wang <seiya.wang@...iatek.com>
>>>>>> Signed-off-by: Zhiyong Tao <zhiyong.tao@...iatek.com>
>>>>>> Signed-off-by: Weiyi Lu <weiyi.lu@...iatek.com>
>>>>>> Signed-off-by: Mengqi Zhang <Mengqi.Zhang@...iatek.com>
>>>>>> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>
>>>>>> Signed-off-by: Eddie Huang <eddie.huang@...iatek.com>
>>>>>> ---
>>>>>
>>>>>
>>>>>> +   sysirq: intpol-controller@...0a80 {
>>>>>
>>>>> interrupt-controller@...
>>>>
>>>> I will modify it in next version.
>>>>>
>>>>>
>>>>> Place all the MMIO peripherals under one or more simple-bus nodes.
>>>>>
>>>>> Rob
>>>>>
>>>>
>>>> Do you mean need to add simple-bus like this?
>>>
>>> Yes.
>>
>> We remove soc because Matthias suggested it in former MTK SoC maybe in
>> 2015 year.
>>
>> We will add it back by your comment.
>>
>> Thank you. 
>>
>> Best Regards,
>> Erin
> 
> Hi, Matthias,
> Do you have any comment here?

Although I wasn't able to find it in the documentation my understanding is, that
all devices on-chip should be under soc "bus".

I'm sorry if I created confusion with comments in the past.

Regards,
Matthias

> Thanks
> 
> Best Regards,
> Erin
>>>
>>>>
>>>> +   soc: soc {
>>>> +                #address-cells = <0x1>;
>>>> +                #size-cells = <0x1>;
>>>> +                ranges = <0 0 0 0xffffffff>;
>>>> +                compatible = "simple-bus";
>>>>
>>>>                 soc_data: soc_data@...00000 {
>>>>                         compatible = "mediatek,mt8183-efuse",
>>>>                                      "mediatek,efuse";
>>>>                         reg = <0 0x08000000 0 0x0010>;
>>>>                         #address-cells = <1>;
>>>>                         #size-cells = <1>;
>>>>                         status = "disabled";
>>>>                 };
>>>>
>>>>                 gic: interrupt-controller@...00000 {
>>>>                         compatible = "arm,gic-v3";
>>>>                         #interrupt-cells = <4>;
>>>>
>>>> Best Regards,
>>>> Erin
>>>>
>>>>> _______________________________________________
>>>>> Linux-mediatek mailing list
>>>>> Linux-mediatek@...ts.infradead.org
>>>>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> linux-arm-kernel mailing list
>>>> linux-arm-kernel@...ts.infradead.org
>>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
> 
> 

Powered by blists - more mailing lists