linux-kernel - Re: [PATCH v7 05/10] clk: bd718x7: Support ROHM BD70528 clk block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190207060104.GB5798@localhost.localdomain>
Date:   Thu, 7 Feb 2019 08:01:04 +0200
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     mazziesaccount@...il.com, Guenter Roeck <linux@...ck-us.net>,
        heikki.haikola@...rohmeurope.com, mikko.mutanen@...rohmeurope.com,
        lee.jones@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
        broonie@...nel.org, gregkh@...uxfoundation.org, rafael@...nel.org,
        mturquette@...libre.com, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, sre@...nel.org, lgirdwood@...il.com,
        a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        wim@...ux-watchdog.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v7 05/10] clk: bd718x7: Support ROHM BD70528 clk block

On Wed, Feb 06, 2019 at 09:31:27AM -0800, Stephen Boyd wrote:
> Quoting Matti Vaittinen (2019-02-06 01:39:38)
> > @@ -86,9 +87,21 @@ static int bd71837_clk_probe(struct platform_device *pdev)
> >                 dev_err(&pdev->dev, "No parent clk found\n");
> >                 return -EINVAL;
> >         }
> > -
> > -       c->reg = BD718XX_REG_OUT32K;
> > -       c->mask = BD718XX_OUT32K_EN;
> > +       switch (mfd->chip_type) {
> > +       case ROHM_CHIP_TYPE_BD71837:
> > +       case ROHM_CHIP_TYPE_BD71847:
> > +
> 
> Nitpick: why the extra newline above?
For no obvious reason. I'll fix this as I need to create new version
anyways. I'll squash the first 3 patches and fix some issues pointed out
by the 0-Day test suite.

Br,
	Matti Vaittinen

-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes.  Just then, he vanished ~~~