linux-kernel - Re: [PATCH v7 00/10] support ROHM BD70528 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190207055738.GA5798@localhost.localdomain>
Date:   Thu, 7 Feb 2019 07:57:38 +0200
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     mazziesaccount@...il.com, Guenter Roeck <linux@...ck-us.net>,
        heikki.haikola@...rohmeurope.com, mikko.mutanen@...rohmeurope.com,
        lee.jones@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
        broonie@...nel.org, gregkh@...uxfoundation.org, rafael@...nel.org,
        mturquette@...libre.com, sboyd@...nel.org,
        linus.walleij@...aro.org, bgolaszewski@...libre.com,
        sre@...nel.org, lgirdwood@...il.com, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, wim@...ux-watchdog.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v7 00/10] support ROHM BD70528 PMIC

Moro Kalle,

On Wed, Feb 06, 2019 at 08:31:32PM +0200, Kalle Valo wrote:
> Matti Vaittinen <matti.vaittinen@...rohmeurope.com> writes:
> 
> > Patch series introducing support for ROHM BD70528 PMIC
> >
> > Please note that patch 1 breaks compilation without patches 2 and 3
> > Knowing the bd718x7 driver is already in upstream, it might be good
> > if this change went through single tree, right?
> 
> That would break bisect, please avoid that. So after applying patches
> from a patchset one by one the compilation should always succeed.

Right. Thanks for the reminder. Mark did also ask about this earlier.
This split was originally done to clearly point out changes impacting
in-tree drivers on separate subsystems/trees (mfd, clk and regulators).

But you are right, these should be squashed before applying. I have now
received acks from Mark and Stephen so I guess I can squash them even
though Lee has not yet commented anything yet. I guess that 7 previous
versions do already clearly enough point out these changes =)

I will squash them in next version. Thanks for the reminder.

> 
> -- 
> Kalle Valo

-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes.  Just then, he vanished ~~~