linux-kernel - Re: [PATCH v3 00/15] Habana Labs kernel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 08 Feb 2019 13:43:09 -0800
From:   Joe Perches <joe@...ches.com>
To:     Oded Gabbay <oded.gabbay@...il.com>,
        Mike Rapoport <rppt@...ux.ibm.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Olof Johansson <olof@...om.net>, ogabbay@...ana.ai,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3 00/15] Habana Labs kernel driver

On Fri, 2019-02-08 at 23:33 +0200, Oded Gabbay wrote:
> On Wed, Feb 6, 2019 at 1:52 PM Mike Rapoport <rppt@...ux.ibm.com> wrote:
> > On Mon, Feb 04, 2019 at 10:32:39PM +0200, Oded Gabbay wrote:
> > > Hello,
> > > This is v3 of the Habana Labs kernel driver patch-set. It contains minor fixes
> > > according to reviews done on v2. In addition, it is rebased on v5.0-rc5.
[]
> > Nit: git am is unhappy about black lines at EOF, e.g:
> > 
> > Applying: habanalabs: add basic Goya support
> > .git/rebase-apply/patch:29: new blank line at EOF.
> > +
> Yes, but on the other hand, joe perches gave me a comment about
> missing newline at end of Makefile.
> So either diff will complain or git am.

Not really.

The desired modification was the last non-blank line of
the Makefile should have a terminating newline, not that
there was a blank line at EOF.