linux-kernel - Re: [PATCH v4 01/16] block: sed-opal: fix typos and formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1549666597.10972.49.camel@intel.com>
Date:   Fri, 8 Feb 2019 22:56:39 +0000
From:   "Derrick, Jonathan" <jonathan.derrick@...el.com>
To:     "hch@...radead.org" <hch@...radead.org>,
        "zub@...ux.fjfi.cvut.cz" <zub@...ux.fjfi.cvut.cz>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "sbauer@...donthack.me" <sbauer@...donthack.me>,
        "jonas.rabenstein@...dium.uni-erlangen.de" 
        <jonas.rabenstein@...dium.uni-erlangen.de>,
        "axboe@...nel.dk" <axboe@...nel.dk>
Subject: Re: [PATCH v4 01/16] block: sed-opal: fix typos and formatting

Looks good otherwise

Reviewed-by: Jon Derrick <jonathan.derrick@...el.com>

On Mon, 2019-02-04 at 21:28 +0100, David Kozub wrote:
> On Mon, 4 Feb 2019, Christoph Hellwig wrote:
> 
> > On Fri, Feb 01, 2019 at 09:50:08PM +0100, David Kozub wrote:
> > > This should make no change in functionality.
> > > The formatting changes were triggered by checkpatch.pl.
> > > 
> > > Signed-off-by: David Kozub <zub@...ux.fjfi.cvut.cz>
> > > Reviewed-by: Scott Bauer <sbauer@...donthack.me>
> > > ---
> > >  block/sed-opal.c | 19 +++++++++++--------
> > >  1 file changed, 11 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/block/sed-opal.c b/block/sed-opal.c
> > > index e0de4dd448b3..c882a193e162 100644
> > > --- a/block/sed-opal.c
> > > +++ b/block/sed-opal.c
> > > @@ -11,8 +11,8 @@
> > >   *
> > >   * This program is distributed in the hope it will be useful, but WITHOUT
> > >   * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> > > - * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> > > - * more details.
> > > + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
> > > + * for more details.
> > 
> > What exactly is the fix here?
> > 
> > If we want to fix the licence boilerplate we should switch it to an
> > SPDX tag instead.
> > 
> > Otherwise this looks fine to me.
> 
> I thought checkpatch.pl -f block/sed-opal.c complained about the line 
> being too long. But when I try that again now (with the original version), 
> it does not complain. So I probably saw a ghost.
> 
> I'll undo this change.
Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (3278 bytes)