[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <yq1zhr5vpos.fsf@oracle.com>
Date: Fri, 08 Feb 2019 18:13:55 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: John Garry <john.garry@...wei.com>
Cc: <jejb@...ux.vnet.ibm.com>, <martin.petersen@...cle.com>,
<linuxarm@...wei.com>, <linux-kernel@...r.kernel.org>,
<linux-scsi@...r.kernel.org>,
Xiang Chen <chenxiang66@...ilicon.com>
Subject: Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw
John,
Just noticed this while inspecting the resulting complete diff:
> static u32 get_prot_chk_msk_v3_hw(struct scsi_cmnd *scsi_cmnd)
> {
> unsigned char prot_flags = scsi_cmnd->prot_flags;
>
> - if (prot_flags & SCSI_PROT_TRANSFER_PI) {
> - if (prot_flags & SCSI_PROT_REF_CHECK)
> - return 0xc << 16;
> - return 0xfc << 16;
> - }
> - return 0;
> + if (prot_flags & SCSI_PROT_REF_CHECK)
> + return T10_CHK_APP_TAG_MSK;
Polarity is a bit unclear here. Is this statement disabling checking of
the app tag?
> + return T10_CHK_REF_TAG_MSK | T10_CHK_APP_TAG_MSK;
> }
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists