linux-kernel - Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53c516cc-cce3-a3e1-718f-6fc465b6e401@hisilicon.com>
Date:   Mon, 11 Feb 2019 19:36:01 +0800
From:   "chenxiang (M)" <chenxiang66@...ilicon.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        John Garry <john.garry@...wei.com>
CC:     <jejb@...ux.vnet.ibm.com>, <linuxarm@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw

Hi Martin,

在 2019/2/9 7:13, Martin K. Petersen 写道:
> John,
>
> Just noticed this while inspecting the resulting complete diff:
>
>>   static u32 get_prot_chk_msk_v3_hw(struct scsi_cmnd *scsi_cmnd)
>>   {
>>   	unsigned char prot_flags = scsi_cmnd->prot_flags;
>>   
>> -	if (prot_flags & SCSI_PROT_TRANSFER_PI) {
>> -		if (prot_flags & SCSI_PROT_REF_CHECK)
>> -			return 0xc << 16;
>> -		return 0xfc << 16;
>> -	}
>> -	return 0;
>> +	if (prot_flags & SCSI_PROT_REF_CHECK)
>> +		return T10_CHK_APP_TAG_MSK;
> Polarity is a bit unclear here. Is this statement disabling checking of
> the app tag?

Yes, disabling checking of app tag.
For here, 1'b0 presents the related byte in DIF will be checked, and 
1'b1 presents the related byte in DIF will not be checked.


>
>> +	return T10_CHK_REF_TAG_MSK | T10_CHK_APP_TAG_MSK;
>>   }