linux-kernel - Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1a7j0tmqt.fsf@oracle.com>
Date:   Tue, 12 Feb 2019 22:01:46 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     "chenxiang \(M\)" <chenxiang66@...ilicon.com>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        John Garry <john.garry@...wei.com>, <jejb@...ux.vnet.ibm.com>,
        <linuxarm@...wei.com>, <linux-kernel@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw


chenxiang,

>>> +	if (prot_flags & SCSI_PROT_REF_CHECK)
>>> +		return T10_CHK_APP_TAG_MSK;

>> Polarity is a bit unclear here. Is this statement disabling checking of
>> the app tag?
>
> Yes, disabling checking of app tag.
> For here, 1'b0 presents the related byte in DIF will be checked, and
> 1'b1 presents the related byte in DIF will not be checked.

OK, thanks for the clarification!

-- 
Martin K. Petersen	Oracle Linux Engineering