linux-kernel - Re: [EXT] Re: [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Feb 2019 12:27:51 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <beanhuo@...ron.com>, <marek.vasut@...il.com>,
        <dwmw2@...radead.org>, <computersforpeace@...il.com>,
        <bbrezillon@...nel.org>, <richard@....at>
CC:     <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS



On 02/08/2019 01:39 PM, Bean Huo (beanhuo) wrote:
> Hi, Tudor
> 
>> SNOR_HWCPAS_READ_OCTO was renamed to SNOR_HWCPAS_READ_OCTAL
>> please update your remote and send a new patch.
>>
> Which branch do you mean? I checked linux-mtd, not renamed yet.

spi-nor/next

> 
>> The patch prefix is wrong, it should be prefixed with "mtd: spi-nor:". When in
>> doubt, you can check how were prefixed previous patches on the same file by
>> running something like:
>>
>> git log --oneline include/linux/mtd/spi-nor.h
>>
>> On 02/07/2019 03:46 PM, Bean Huo (beanhuo) wrote:
>>>
>>
>> This looks like a blank line, it's not needed, remove it please.
>>> Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS.
>>
>> Indeed, it is, use imperative, something like: "Fix wrong abbreviation,
>> s/HWCPAS/HWCAPS"
>>>
>>> Signed-off-by: Bean Huo <beanhuo@...ron.com>
>>
>> Your S-o-b tag doesn't match the author name, please fix this as well.
> 
> It is automatically added by git, what is correct way?

Your author name "Bean Huo (beanhuo)" is different than your S-o-b name, "Bean
Huo". Did you add your S-o-b tag by hand? The author name is automatically added
by git, it looks into your ~/.gitconfig file, at [user] name. S-o-b tag can also
be added by git, just use the "-s" option when committing the change: "git
commit -s".

Cheers,
ta