linux-kernel - Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b60a0c35-6e5a-4166-9dd8-3891fce1cd0b@linaro.org>
Date:   Fri, 8 Feb 2019 14:01:33 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     arnd@...db.de, robh+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, bjorn.andersson@...aro.org,
        bkumar@....qualcomm.com, linux-arm-msm@...r.kernel.org,
        Thierry Escande <thierry.escande@...aro.org>
Subject: Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke
 method

Thanks for the review,

On 08/02/2019 13:55, Greg KH wrote:
>> +
>> +		/* Make sure reserved field is set to 0 */
>> +		if (args->reserved) {
>> +			kfree(args);
>> +			return -EINVAL;
> Am I wrong in that you are only checking the first reserved field in
> this array of args?  Don't you have a whole bunch of them here (nscalars
> of them)?  Don't you need to check them all and not just the first one?
My Bad, there should be a loop here!
I will fix this in next version!

--srini