linux-kernel - Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190208141120.GA9516@kroah.com>
Date:   Fri, 8 Feb 2019 15:11:20 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     arnd@...db.de, robh+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, bjorn.andersson@...aro.org,
        bkumar@....qualcomm.com, linux-arm-msm@...r.kernel.org,
        Thierry Escande <thierry.escande@...aro.org>
Subject: Re: [PATCH v6 3/5] misc: fastrpc: Add support for context Invoke
 method

On Fri, Feb 08, 2019 at 02:01:33PM +0000, Srinivas Kandagatla wrote:
> Thanks for the review,
> 
> On 08/02/2019 13:55, Greg KH wrote:
> > > +
> > > +		/* Make sure reserved field is set to 0 */
> > > +		if (args->reserved) {
> > > +			kfree(args);
> > > +			return -EINVAL;
> > Am I wrong in that you are only checking the first reserved field in
> > this array of args?  Don't you have a whole bunch of them here (nscalars
> > of them)?  Don't you need to check them all and not just the first one?
> My Bad, there should be a loop here!
> I will fix this in next version!

No, you don't need to loop it here, check it in the call that evaluates
the individual args, which will catch the issue when people send
"internal" commands.

Which reminds me, what happens if a sequence has problems half way
through the list of args?  Do you "roll back" to the beginning, or just
abort?  What happens to the internal device state then?

thanks,

greg k-h