linux-kernel - Re: [PATCH v3 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <81bef334-0b27-22dd-d8a2-3d172204e69d@linux.ibm.com>
Date:   Fri, 8 Feb 2019 11:48:04 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        linux-integrity@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Peter Huewe <PeterHuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        Alexander Steffen <Alexander.Steffen@...ineon.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH v3 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer
 is incomplete

On 2/8/19 11:30 AM, Jarkko Sakkinen wrote:
> Return -E2BIG when the transfer is incomplete. The upper layer does
> not retry, so not doing that is incorrect behaviour.
>
> Cc: stable@...r.kernel.org
> Fixes: a2871c62e186 ("tpm: Add support for Atmel I2C TPMs")
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> ---
>   drivers/char/tpm/tpm_i2c_atmel.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
> index aa11c8a1df5e..8a7e80923091 100644
> --- a/drivers/char/tpm/tpm_i2c_atmel.c
> +++ b/drivers/char/tpm/tpm_i2c_atmel.c
> @@ -69,6 +69,10 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len)
>   	if (status < 0)
>   		return status;
>
> +	/* The upper layer does not support incomplete sends. */
> +	if (status != len)
> +		return -E2BIG;
> +
>   	return 0;
>   }
>
Reviewed-by: Stefan Berger <stefanb@...ux.ibm.com>