linux-kernel - Re: [PATCH v4 0/2] tpm: Unify send() callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190209200838.2matnb5dqlnr4qdx@cantor>
Date:   Sat, 9 Feb 2019 13:08:38 -0700
From:   Jerry Snitselaar <jsnitsel@...hat.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Peter Huewe <PeterHuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        Alexander Steffen <Alexander.Steffen@...ineon.com>
Subject: Re: [PATCH v4 0/2] tpm: Unify send() callbacks

On Fri Feb 08 19, Jarkko Sakkinen wrote:
>From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.co m>
>
>A portion of send() callbacks have returned length, in many cases just
>returning back what was given as an argument, and tpm_crb has returned 0 on
>success. This patch set fixes and unifies the behaviour.
>
>v4:
>* Return zero already in tpm_tis_send_main() so that it is applied to all
>  call sites of tpm_tis_send().
>* Fixup tpm_ibmvtpm_send() documentation.
>v3:
>tpm_tis_core fix was left out of the staging area :-(
>v2:
>The drivers tpm_nsc and tpm_infineon were forgotten. For this version I
>checked both with find and command and from Kconfig that everything that is
>supposed to be a driver directly interfacing with the TPM core, is included
>(e.g. discluding tpm_tis_spi).
>
>Jarkko Sakkinen (2):
>  tpm: Unify the send callback behaviour
>  tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete
>
> drivers/char/tpm/st33zp24/st33zp24.c |  2 +-
> drivers/char/tpm/tpm_atmel.c         |  2 +-
> drivers/char/tpm/tpm_i2c_atmel.c     | 10 +++++++++-
> drivers/char/tpm/tpm_i2c_infineon.c  |  2 +-
> drivers/char/tpm/tpm_i2c_nuvoton.c   |  2 +-
> drivers/char/tpm/tpm_ibmvtpm.c       |  8 ++++----
> drivers/char/tpm/tpm_infineon.c      |  2 +-
> drivers/char/tpm/tpm_nsc.c           |  2 +-
> drivers/char/tpm/tpm_tis_core.c      |  2 +-
> drivers/char/tpm/tpm_vtpm_proxy.c    |  3 +--
> drivers/char/tpm/xen-tpmfront.c      |  2 +-
> 11 files changed, 22 insertions(+), 15 deletions(-)
>
>-- 
>2.19.1
>

Reviewed-by: Jerry Snitselaar <jsnitsel@...hat.com>