linux-kernel - Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45be0d68-8382-64bc-dcd0-0e86462e6e66@redhat.com>
Date:   Sat, 9 Feb 2019 12:32:56 -0800
From:   Laura Abbott <labbott@...hat.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Arnd Bergmann <arnd@...db.de>, Martin Sebor <msebor@....gnu.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Jessica Yu <jeyu@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        James Morris <james.morris@...rosoft.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Borislav Petkov <bp@...e.de>, Matt Mullins <mmullins@...com>,
        Vincent Whitchurch <vincent.whitchurch@...s.com>,
        WANG Chao <chao.wang@...oud.cn>
Subject: Re: [PATCH 0/3] Clean the new GCC 9 -Wmissing-attributes warnings

On 2/9/19 12:08 AM, Miguel Ojeda wrote:
> The upcoming GCC 9 release extends the -Wmissing-attributes warnings
> (enabled by -Wall) to C and aliases: it warns when particular function
> attributes are missing in the aliases but not in their target, e.g.:
> 
>      void __cold f(void) {}
>      void __alias("f") g(void);
> 
> diagnoses:
> 
>      warning: 'g' specifies less restrictive attribute than
>      its target 'f': 'cold' [-Wmissing-attributes]
> 
> These patch series clean these new warnings. Most of them are caused
> by the module_init/exit macros.
> 
> The first patch has been in -next for a long time already, and an alternative
> solution (only __cold) for module.h as well. However, since we decided
> to go with the new __copy attribute, I will leave the series for a few days
> again and send the PR for -rc7.
> 
> Link: https://lore.kernel.org/lkml/20190125104353.2791-1-labbott@redhat.com/
> 
> Miguel Ojeda (3):
>    lib/crc32.c: mark crc32_le_base/__crc32c_le_base aliases as __pure
>    Compiler Attributes: add support for __copy (gcc >= 9)
>    include/linux/module.h: copy __init/__exit attrs to
>      init/cleanup_module
> 
>   include/linux/compiler_attributes.h | 14 ++++++++++++++
>   include/linux/module.h              |  4 ++--
>   lib/crc32.c                         |  4 ++--
>   3 files changed, 18 insertions(+), 4 deletions(-)
> 


For the entire series:

Tested-by: Laura Abbott <labbott@...hat.com>

You can look at the full build logs at
https://koji.fedoraproject.org/koji/taskinfo?taskID=326911 .

Thanks,
Laura