linux-kernel - Re: [GIT PULL] signal fixes for v5.0-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190211164755.GD21430@redhat.com>
Date:   Mon, 11 Feb 2019 17:47:56 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Dmitry Vyukov <dvyukov@...gle.com>,
        Jack Andersen <jackoalan@...il.com>,
        Christian Brauner <christian@...uner.io>,
        Kees Cook <keescook@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [GIT PULL] signal fixes for v5.0-rc6

On 02/08, Eric W. Biederman wrote:
>
>       signal: Always notice exiting tasks

Sorry, I could not look at these patches before...

So I think this one should be reverted, it makes PTRACE_EVENT_EXIT even more broken.

Once again, why we can't do something like

	--- x/kernel/signal.c
	+++ x/kernel/signal.c
	@@ -209,6 +209,8 @@ int next_signal(struct sigpending *pendi
		 */
		x = *s &~ *m;
		if (x) {
	+		if (x & sigmask(SIGKILL))
	+			return SIGKILL;
			if (x & SYNCHRONOUS_MASK)
				x &= SYNCHRONOUS_MASK;
			sig = ffz(~x) + 1;

instead? at least for the start.

Oleg.