linux-kernel - Re: [RESEND PATCH v2 13/33] ARM: davinci: aintc: use readl/writel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98530970-e49c-cce1-d2f7-749e18430dad@arm.com>
Date:   Mon, 11 Feb 2019 12:54:27 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Bartosz Golaszewski <brgl@...ev.pl>, Sekhar Nori <nsekhar@...com>,
        Kevin Hilman <khilman@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        David Lechner <david@...hnology.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [RESEND PATCH v2 13/33] ARM: davinci: aintc: use
 readl/writel_relaxed()

On 11/02/2019 12:25, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> Raplace all calls to __raw_readl() & __raw_writel() with readl_relaxed()
> and writel_relaxed() respectively. It's safe to do as there's no
> endianness conversion being done in the code.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
>  arch/arm/mach-davinci/irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-davinci/irq.c b/arch/arm/mach-davinci/irq.c
> index 148c23728bdb..6a7205a844e1 100644
> --- a/arch/arm/mach-davinci/irq.c
> +++ b/arch/arm/mach-davinci/irq.c
> @@ -36,12 +36,12 @@ static struct irq_domain *davinci_aintc_irq_domain;
>  
>  static inline void davinci_aintc_writel(unsigned long value, int offset)
>  {
> -	__raw_writel(value, davinci_aintc_base + offset);
> +	writel_relaxed(value, davinci_aintc_base + offset);
>  }
>  
>  static inline unsigned long davinci_aintc_readl(int offset)
>  {
> -	return __raw_readl(davinci_aintc_base + offset);
> +	return readl_relaxed(davinci_aintc_base + offset);
>  }
>  
>  static __init void
> 

Right. And that's exactly what I'd like to see in patch #3. There is no
point having a separate patch for this when you can do the right thing
from the beginning.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...