linux-kernel - Re: [PATCH 4/4] iio: counter: stm32-lptimer: Add power management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7abbd3e2-4a33-975a-39ee-dcf608633b36@st.com>
Date:   Mon, 11 Feb 2019 14:21:25 +0100
From:   Fabrice Gasnier <fabrice.gasnier@...com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Jonathan Cameron <jic23@...nel.org>
CC:     <thierry.reding@...il.com>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <alexandre.torgue@...com>,
        <mcoquelin.stm32@...il.com>, <linux-iio@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-pwm@...r.kernel.org>,
        <vilhelm.gray@...il.com>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH 4/4] iio: counter: stm32-lptimer: Add power management
 support

On 2/10/19 10:33 PM, Uwe Kleine-König wrote:
> On Sat, Feb 09, 2019 at 04:21:33PM +0000, Jonathan Cameron wrote:
>> On Tue, 5 Feb 2019 13:40:29 +0100
>> Fabrice Gasnier <fabrice.gasnier@...com> wrote:
>>
>>> Add suspend/resume PM sleep ops. When going to low power, disable
>>> active counter. Only active counter should be resumed: don't touch
>>> disabled counter, as it may be used by other LPTimer MFD child driver.
>>>
>>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...com>
>> I think this looks fine.  I'm not totally sure if patches 3,4 are
>> separable from 1,2 though so please let me know whether I should take
>> these now, or let all 4 go in together via some path?
> 
> I'd say these are orthogonal, so if you are happy with patches 3 and 4
> you can take them without bothering for patches 1 and 2.

Hi Uwe, Jonathan,

Thanks for reviewing. I confirm you can take patches 3 and 4. I'll send
a v2 for patches 1 and 2 separately.

Best regards,
Fabrice

> 
> Best regards
> Uwe
>