linux-kernel - Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPtwhKpqggL1k8wsh-ECS6aUr7qThUyHjgx9BGeL84bCbj9Lvw@mail.gmail.com>
Date:   Tue, 12 Feb 2019 12:00:18 -0800
From:   Xuewei Zhang <xueweiz@...gle.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        James Bottomley <James.Bottomley@...senpartnership.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mikael Pettersson <mikpelinux@...il.com>,
        Theodore Tso <tytso@...gle.com>
Subject: Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks

Thanks for the fix James!

On Tue, Feb 12, 2019 at 8:59 AM Martin K. Petersen
<martin.petersen@...cle.com> wrote:
>
>
> Jens,
>
> >> The fix is to set the non-rotational and add-randomness flags
> >> unconditionally early on in the disk initialization path, so they can
> >> be reset only if the device actually reports being non-rotational via
> >> the VPD page.
> >
> > Reviewed-by: Jens Axboe <axboe@...nel.dk>

Reviewed-by: Xuewei Zhang <xueweiz@...gle.com>

>
> Yeah, this looks good to me. I'll queue it up for fixes.
>
> --
> Martin K. Petersen      Oracle Linux Engineering