linux-kernel - Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1zhr1t028.fsf@oracle.com>
Date:   Tue, 12 Feb 2019 11:59:27 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     James Bottomley <James.Bottomley@...senPartnership.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        Xuewei Zhang <xueweiz@...gle.com>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Mikael Pettersson <mikpelinux@...il.com>
Subject: Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks


Jens,

>> The fix is to set the non-rotational and add-randomness flags
>> unconditionally early on in the disk initialization path, so they can
>> be reset only if the device actually reports being non-rotational via
>> the VPD page.
>
> Reviewed-by: Jens Axboe <axboe@...nel.dk>

Yeah, this looks good to me. I'll queue it up for fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering