linux-kernel - Re: [PATCH] hwmon: (f71882fg) Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190212215105.GA17643@roeck-us.net>
Date:   Tue, 12 Feb 2019 13:51:05 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] hwmon: (f71882fg) Mark expected switch fall-through

On Mon, Feb 11, 2019 at 04:07:38PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warnings:
> 
> drivers/hwmon/f71882fg.c: In function ‘f71882fg_probe’:
> drivers/hwmon/f71882fg.c:2457:33: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     data->auto_point_temp_signed = 1;
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/hwmon/f71882fg.c:2459:3: note: here
>    case f71889fg:
>    ^~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/f71882fg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
> index ca54ce5c8e10..83023798e489 100644
> --- a/drivers/hwmon/f71882fg.c
> +++ b/drivers/hwmon/f71882fg.c
> @@ -2455,7 +2455,7 @@ static int f71882fg_probe(struct platform_device *pdev)
>  		case f71869a:
>  			/* These always have signed auto point temps */
>  			data->auto_point_temp_signed = 1;
> -			/* Fall through to select correct fan/pwm reg bank! */
> +			/* Fall through - to select correct fan/pwm reg bank! */
>  		case f71889fg:
>  		case f71889ed:
>  		case f71889a: