linux-kernel - Re: [PATCH 2/2] selftests: tpm2: Extend tests to cover partial reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Feb 2019 01:06:55 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Tadeusz Struk <tadeusz.struk@...el.com>
Cc:     linux-kselftest@...r.kernel.org, shuah@...nel.org,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, PeterHuewe@....de,
        jgg@...pe.ca
Subject: Re: [PATCH 2/2] selftests: tpm2: Extend tests to cover partial reads

On Mon, Feb 11, 2019 at 09:55:36AM -0800, Tadeusz Struk wrote:
> On 2/11/19 8:48 AM, Jarkko Sakkinen wrote:
> > You are missing a cover letter from this patch set. Please have it in
> > v2. Also use tag "selftests/tpm2" instead of having two tags in the
> > short summaries. Now they look a bit weird.
> 
> Since when is the cover letter mandatory?
> I understand that is helps for a complicated patch set
> to explain the problem and solution in the cover letter,
> but for this simple test case addition what's the point?
> And there is nothing forcing a cover letter in
> https://www.kernel.org/doc/html/v4.20/process/submitting-patches.html

OK, cool.

> Also double tags seams to be quite common for selftest.
> See git log tools/testing/selftests/

Prefer slash for TPM specific commits.

I can merge this after those extra logs are removed.

/Jarkko