linux-kernel - Re: [PATCH] gpio: sprd: Add missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Feb 2019 10:07:26 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] gpio: sprd: Add missing break in switch statement

Hi Gustavo,

On Tue, 12 Feb 2019 at 02:50, Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
>
> Fix the following warning by adding a missing break:
>
> drivers/gpio/gpio-eic-sprd.c: In function ‘sprd_eic_irq_set_type’:
> drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    switch (flow_type) {
>    ^~~~~~
> drivers/gpio/gpio-eic-sprd.c:435:2: note: here
>   default:
>   ^~~~~~~
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Thanks for fixing my mistake.
Reviewed-by: Baolin Wang <baolin.wang@...aro.org>

> ---
>  drivers/gpio/gpio-eic-sprd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index e41223c05f6e..f0223cee9774 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -432,6 +432,7 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
>                 default:
>                         return -ENOTSUPP;
>                 }
> +               break;
>         default:
>                 dev_err(chip->parent, "Unsupported EIC type.\n");
>                 return -ENOTSUPP;
> --
> 2.20.1
>


-- 
Baolin Wang
Best Regards