linux-kernel - Re: [PATCH] gpio: sprd: Add missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aeb131be-bc0d-3195-d40d-3c78b334a51a@embeddedor.com>
Date:   Mon, 11 Feb 2019 20:11:14 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] gpio: sprd: Add missing break in switch statement

Hi Baolin,

On 2/11/19 8:07 PM, Baolin Wang wrote:
> Hi Gustavo,
> 
> On Tue, 12 Feb 2019 at 02:50, Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>>
>> Fix the following warning by adding a missing break:
>>
>> drivers/gpio/gpio-eic-sprd.c: In function ‘sprd_eic_irq_set_type’:
>> drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    switch (flow_type) {
>>    ^~~~~~
>> drivers/gpio/gpio-eic-sprd.c:435:2: note: here
>>   default:
>>   ^~~~~~~
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Thanks for fixing my mistake.
> Reviewed-by: Baolin Wang <baolin.wang@...aro.org>
> 

Glad to help. :)

Thanks
--
Gustavo