linux-kernel - Re: [tip:locking/core] sched/wake_q: Reduce reference counting for special users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1549980892-28583-1-git-send-email-neelx@redhat.com>
Date:   Tue, 12 Feb 2019 15:14:52 +0100
From:   Daniel Vacek <neelx@...hat.com>
To:     tipbot@...or.com
Cc:     akpm@...ux-foundation.org, dave@...olabs.net, dbueso@...e.de,
        elohimes@...il.com, hpa@...or.com, linux-kernel@...r.kernel.org,
        linux-tip-commits@...r.kernel.org, longman@...hat.com,
        mingo@...nel.org, paulmck@...ux.vnet.ibm.com, peterz@...radead.org,
        tglx@...utronix.de, torvalds@...ux-foundation.org,
        will.deacon@....com, xieyongji@...du.com, neelx@...hat.com
Subject: Re: [tip:locking/core] sched/wake_q: Reduce reference counting for special users

> diff --git a/kernel/futex.c b/kernel/futex.c
> index 69e619baf709..2abe1a0b3062 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -1463,8 +1463,7 @@ static void mark_wake_futex(struct wake_q_head *wake_q, struct futex_q *q)
>  	 * Queue the task for later wakeup for after we've released
>  	 * the hb->lock. wake_q_add() grabs reference to p.

Should this comment be fixed as well?

--nX

>  	 */
> -	wake_q_add(wake_q, p);
> -	put_task_struct(p);
> +	wake_q_add_safe(wake_q, p);
>  }
>  
>  /*