linux-kernel - Re: [PATCH v2 00/10] ICL support and other enhancements for PMC Core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Feb 2019 19:28:01 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@...ux.intel.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 00/10] ICL support and other enhancements for PMC Core

On Wed, Feb 13, 2019 at 5:50 PM Bhardwaj, Rajneesh
<rajneesh.bhardwaj@...ux.intel.com> wrote:
> On 13-Feb-19 9:03 PM, Andy Shevchenko wrote:
> > On Wed, Feb 13, 2019 at 5:08 PM Rajneesh Bhardwaj
> > <rajneesh.bhardwaj@...ux.intel.com> wrote:
> >> This patch series provides Icelake support for PMC Core driver and while
> >> doing so it introduces the Icelake Mobile to intel-family.h as per the
> >> CPUID from below Coreboot link
> >> https://github.com/coreboot/coreboot/blob/5ebcea3aaaa3cd358bc5bccaa156b13a6ef25df6/src/soc/intel/common/block/include/intelblocks/mp_init.h
> >> and provides some fixes and enhancements to the driver.
> > It's not applicable to my tree.
>
> Hi Andy,  I could apply and test in on latest upstream so i think its
> probably because you have applied 5 patches from v1 on your tree.
> https://github.com/dvhart/linux-pdx86/commits/for-next

You need to use latest tip of the subsystem tree always.

> I sent the whole series again since
> https://patchwork.kernel.org/patch/10791893 referred to a wrong commit
> for Fixes:. If you want to address that by rebasing then can you please
> just consider patches 6-10.

We don't do rebasing for published changes. Only in rear cases when
otherwise would be worse.
Darren didn't respond to my question what he thinks about this case,
but at least it's not related to the code itself which, in my opinion,
decreases a severity.

> Please let me know if there is any other issue?


-- 
With Best Regards,
Andy Shevchenko