linux-kernel - Re: [PATCH] mtd: lpddr_cmds: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d580e44-6edb-3692-a3ff-21e356689364@embeddedor.com>
Date:   Wed, 13 Feb 2019 12:11:08 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Boris Brezillon <bbrezillon@...nel.org>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] mtd: lpddr_cmds: Mark expected switch fall-through



On 2/13/19 8:05 AM, Boris Brezillon wrote:
> On Tue, 12 Feb 2019 09:31:31 -0600
> "Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:
> 
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’:
>> drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    if (mode == FL_READY && chip->oldstate == FL_READY)
>>       ^
>> drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here
>>   default:
>>   ^~~~~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
> 
> You sent me that one twice, is that expected? Is this a new version,
> and in that case, what has changed?
> 

Oh, it wasn't intentional.  Both are exactly the same patch.

Sorry about that.

--
Gustavo