linux-kernel - Re: [PATCH] tracing/probes: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8cd6bd9c-8724-ccb5-f83d-6367dac465a7@embeddedor.com>
Date:   Wed, 13 Feb 2019 12:18:56 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] tracing/probes: Mark expected switch fall-through



On 2/13/19 8:04 AM, Steven Rostedt wrote:
> On Tue, 12 Feb 2019 15:10:40 -0600
> "Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:
> 
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> kernel/trace/trace_probe.c: In function ‘parse_probe_arg’:
>> kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    arg++; /* Skip '+', because kstrtol() rejects it. */
>>    ~~~^~
>> kernel/trace/trace_probe.c:303:2: note: here
>>   case '-':
>>   ^~~~
> 
> I also already applied this patch (still need to run through tests)
> 
>   http://lkml.kernel.org/r/20190114203039.16535-1-malat@debian.org
> 

Oh, that's great. :)

Thanks
--
Gustavo