linux-kernel - Re: [PATCH] tracing/probes: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190213090401.5b501e15@gandalf.local.home>
Date:   Wed, 13 Feb 2019 09:04:01 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] tracing/probes: Mark expected switch fall-through

On Tue, 12 Feb 2019 15:10:40 -0600
"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:

> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> kernel/trace/trace_probe.c: In function ‘parse_probe_arg’:
> kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    arg++; /* Skip '+', because kstrtol() rejects it. */
>    ~~~^~
> kernel/trace/trace_probe.c:303:2: note: here
>   case '-':
>   ^~~~

I also already applied this patch (still need to run through tests)

  http://lkml.kernel.org/r/20190114203039.16535-1-malat@debian.org

-- Steve

> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  kernel/trace/trace_probe.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 9962cb5da8ac..89da34b326e3 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -300,6 +300,7 @@ parse_probe_arg(char *arg, const struct fetch_type *type,
>  
>  	case '+':	/* deref memory */
>  		arg++;	/* Skip '+', because kstrtol() rejects it. */
> +		/* fall through */
>  	case '-':
>  		tmp = strchr(arg, '(');
>  		if (!tmp)