lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190213083519.tynjs3ef6tnvvsms@ninjato>
Date:   Wed, 13 Feb 2019 09:35:20 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Peter Rosin <peda@...ntia.se>,
        Sowjanya Komatineni <skomatineni@...dia.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "mkarthik@...dia.com" <mkarthik@...dia.com>,
        "smohammed@...dia.com" <smohammed@...dia.com>,
        "talho@...dia.com" <talho@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH V19 1/7] i2c: tegra: sort all the include headers
 alphabetically


> > "^ Header removal should be mentioned in the commit message, I think."
> > - Wolfram Sang [0]
> > 
> > Cheers,
> > Peter
> > 
> > [0] https://lkml.org/lkml/2019/2/11/375
> > 
> 
> It could make sense to adjust the comment only if there will be
> anything else worthwhile a new revision, otherwise it is
> not-so-important. 

Not quite. Addressing review comments and proper commit messages are
both important. So, it needs to be fixed. Yes, I can fix this small
issue locally here (and I will do this, so no need to resend), but this
is ultimately my decision (which you can surely ask for but not
rely on).

I'll apply this series later today.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ