linux-kernel - Re: [PATCH v2 08/21] ASoC: samsung: i2s: Drop spinlock pointer from i2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190213115046.GB7540@sirena.org.uk>
Date:   Wed, 13 Feb 2019 11:50:46 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:     lgirdwood@...il.com, krzk@...nel.org, sbkim73@...sung.com,
        m.szyprowski@...sung.com, b.zolnierkie@...sung.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v2 08/21] ASoC: samsung: i2s: Drop spinlock pointer from
 i2s_dai data structure

On Tue, Feb 12, 2019 at 07:03:29PM +0100, Sylwester Nawrocki wrote:
> As we now have the 'priv' pointer in most of the places we can use
> priv->lock directly, dropping extra indirection in the SFR region
> spinlock access.

This doesn't build for me:

  CC      sound/soc/samsung/i2s.o
In file included from ./include/linux/spinlock.h:309,
                 from ./include/linux/mmzone.h:8,
                 from ./include/linux/gfp.h:6,
                 from ./include/linux/slab.h:15,
                 from sound/soc/samsung/i2s.c:15:
sound/soc/samsung/i2s.c: In function ‘samsung_i2s_dai_remove’:
sound/soc/samsung/i2s.c:1109:23: error: ‘priv’ undeclared (first use in this function); did you mean ‘pid’?
    spin_lock_irqsave(&priv->lock, flags);
                       ^~~~

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)