linux-kernel - Re: [PATCH v2] exec: load_script: Allow interpreter argument truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLYJyz+afGrMp_KbvL2xiwg3h6Cz_q6fQjXL9gpbej7QA@mail.gmail.com>
Date:   Thu, 14 Feb 2019 10:10:25 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Samuel Dionne-Riel <samuel@...nne-riel.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Richard Weinberger <richard.weinberger@...il.com>,
        Graham Christensen <graham@...hamc.com>,
        Michal Hocko <mhocko@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] exec: load_script: Allow interpreter argument truncation

On Thu, Feb 14, 2019 at 9:59 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Thu, Feb 14, 2019 at 8:43 AM Kees Cook <keescook@...omium.org> wrote:
> >
> > This documents the parsing steps, and will fail to exec if the string was
> > truncated with neither an end-of-line nor any trailing whitespace.
>
> Is there any reason why we don't just revert 8099b047ecc4 ("exec:
> load_script: don't blindly truncate shebang string").
>
> That revert patch would seem to be much simpler than this rather
> complicated thing.

We certainly can, but we'll still need to fix the "don't exec a
truncated interpreter path" problem (which this fixes).

I'm happy to do it as two steps instead: revert, then a separate fix
to land in the merge window?

-- 
Kees Cook