linux-kernel - Re: [PATCH v2] exec: load_script: Allow interpreter argument truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wgNt+Pm89Cqp5onH2dQN2ddAV-GU5ZftgrBpupx3h+juA@mail.gmail.com>
Date:   Thu, 14 Feb 2019 15:07:12 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Samuel Dionne-Riel <samuel@...nne-riel.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Richard Weinberger <richard.weinberger@...il.com>,
        Graham Christensen <graham@...hamc.com>,
        Michal Hocko <mhocko@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] exec: load_script: Allow interpreter argument truncation

On Thu, Feb 14, 2019 at 10:10 AM Kees Cook <keescook@...omium.org> wrote:>
> We certainly can, but we'll still need to fix the "don't exec a
> truncated interpreter path" problem (which this fixes).
>
> I'm happy to do it as two steps instead: revert, then a separate fix
> to land in the merge window?

I think that's better. It should also be fairly easy: just look for
whitespace in the truncated output (in the place where we already
check for the "oh, we truncated")

It's even possible that somebody depends on a truncated interpreter
executable name. Unlikely, but possiible. So I'd rather just revert,
and re-try the smaller approach for 5.1.

               Linus