linux-kernel - Re: [PATCH 3/5] soc: qcom: socinfo: Expose custom attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7da4c05d211ed71795bcbad0ded3614979a664c6.camel@perches.com>
Date:   Wed, 13 Feb 2019 20:52:28 -0800
From:   Joe Perches <joe@...ches.com>
To:     Vaishali Thakkar <vaishali.thakkar@...aro.org>,
        andy.gross@...aro.org
Cc:     david.brown@...aro.org, gregkh@...uxfoundation.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        rafael@...nel.org, bjorn.andersson@...aro.org, vkoul@...nel.org
Subject: Re: [PATCH 3/5] soc: qcom: socinfo: Expose custom attributes

On Thu, 2019-02-14 at 09:11 +0530, Vaishali Thakkar wrote:
> The Qualcomm socinfo provides a number of additional attributes,
> add these to the socinfo driver and expose them via debugfs
> functionality.

trivia:

> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
[]
> @@ -70,6 +93,10 @@ struct socinfo {
>  struct qcom_socinfo {
>  	struct soc_device *soc_dev;
>  	struct soc_device_attribute attr;
> +	#ifdef CONFIG_DEBUG_FS
> +	struct dentry *dbg_root;
> +	#endif /* CONFIG_DEBUG_FS */

It's generally better to move the #ifdef/#endif to column 1