linux-kernel - Re: [PATCH 3/5] soc: qcom: socinfo: Expose custom attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190214094106.GA10895@kroah.com>
Date:   Thu, 14 Feb 2019 10:41:06 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Vaishali Thakkar <vaishali.thakkar@...aro.org>
Cc:     andy.gross@...aro.org, david.brown@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        rafael@...nel.org, bjorn.andersson@...aro.org, vkoul@...nel.org
Subject: Re: [PATCH 3/5] soc: qcom: socinfo: Expose custom attributes

On Thu, Feb 14, 2019 at 09:11:49AM +0530, Vaishali Thakkar wrote:
> +static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo)
> +{
> +	qcom_socinfo->dbg_root = debugfs_create_dir("qcom_socinfo", NULL);
> +
> +	if (!qcom_socinfo->dbg_root) {
> +		pr_err("Cannot create debugfs directory\n");
> +		return;
> +	}

No need to check this at all, just call debugfs_create_dir() and be done
with it.



> +
> +	DEBUGFS_UINT_ADD(raw_version);
> +	DEBUGFS_UINT_ADD(hardware_platform);
> +	DEBUGFS_UINT_ADD(platform_version);
> +	DEBUGFS_UINT_ADD(foundry_id);
> +	DEBUGFS_HEX_ADD(chip_family);
> +	DEBUGFS_HEX_ADD(raw_device_family);
> +	DEBUGFS_HEX_ADD(raw_device_number);
> +	DEBUGFS_ADD(build_id);
> +	DEBUGFS_ADD(accessory_chip);
> +	DEBUGFS_ADD(pmic_model);
> +	DEBUGFS_ADD(platform_subtype);
> +	DEBUGFS_ADD(pmic_die_revision);
> +}
> +
> +static void socinfo_debugfs_exit(struct qcom_socinfo *qcom_socinfo)
> +{
> +	debugfs_remove_recursive(qcom_socinfo->dbg_root);
> +}
> +#else
> +socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo) { return 0; }
> +socinfo_debugfs_exit(struct qcom_socinfo *qcom_socinfo) { return 0; }

These function signatures do not match the ones above :(


thanks,

greg k-h