linux-kernel - Re: [PATCH] gpio: pxa: avoid attempting to set pin direction via pinctrl on MMP2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50fa8c81950e8bb2583a65bfd920bdf574c9abc1.camel@v3.sk>
Date:   Thu, 14 Feb 2019 09:52:52 +0100
From:   Lubomir Rintel <lkundrak@...sk>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Robert Jarzmik <robert.jarzmik@...e.fr>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-gpio@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Pavel Machek <pavel@....cz>
Subject: Re: [PATCH] gpio: pxa: avoid attempting to set pin direction via
 pinctrl on MMP2

On Thu, 2019-02-14 at 09:13 +0100, Linus Walleij wrote:
> On Thu, Feb 14, 2019 at 12:06 AM Lubomir Rintel <lkundrak@...sk> wrote:
> 
> > Similarly to PXA3xx, pinctrl-single can't set pin direction on MMP2 either.
> > See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
> > PXA3xx")
> > 
> > Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request")
> > Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> > Acked-by: Pavel Machek <pavel@....cz>
> 
> Patch applied for fixes.
> 
> Should this even go into stable?

I would tend to think it should.

This caused a regression for MMP2 platforms that don't use a pinctrl
driver, and none of them do.

On the other hand it went unnoticed since v4.5.

I've seen stable maintainers pick up fixes even when stable@ wasn't
Cc'd. I guess they apply some heuristics and perhaps look at Fixes:
tags to identify bugfixes?

> Yours,
> Linus Walleij

Lubo