linux-kernel - Re: [PATCH] gpio: pxa: avoid attempting to set pin direction via pinctrl on MMP2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Feb 2019 10:05:34 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Robert Jarzmik <robert.jarzmik@...e.fr>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Pavel Machek <pavel@....cz>
Subject: Re: [PATCH] gpio: pxa: avoid attempting to set pin direction via
 pinctrl on MMP2

On Thu, Feb 14, 2019 at 9:52 AM Lubomir Rintel <lkundrak@...sk> wrote:
> On Thu, 2019-02-14 at 09:13 +0100, Linus Walleij wrote:
> > On Thu, Feb 14, 2019 at 12:06 AM Lubomir Rintel <lkundrak@...sk> wrote:
> >
> > > Similarly to PXA3xx, pinctrl-single can't set pin direction on MMP2 either.
> > > See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
> > > PXA3xx")
> > >
> > > Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request")
> > > Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> > > Acked-by: Pavel Machek <pavel@....cz>
> >
> > Patch applied for fixes.
> >
> > Should this even go into stable?
>
> I would tend to think it should.

OK I tag it for stable.

> This caused a regression for MMP2 platforms that don't use a pinctrl
> driver, and none of them do.
>
> On the other hand it went unnoticed since v4.5.
>
> I've seen stable maintainers pick up fixes even when stable@ wasn't
> Cc'd. I guess they apply some heuristics and perhaps look at Fixes:
> tags to identify bugfixes?

Yes Sasha Levin has an some machine-learning AI that looks at patches
to see if they are elegible for stable, and sometimes people tell
Greg directly to pick a patch, and sometimes Greg just picks a patch
he likes.

But to make things easier for the stable maintainers, it's best to CC stable.

Yours,
Linus Walleij