linux-kernel - [PATCH] usb: dwc2: hcd: call dwc2_is_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1550138622-10761-1-git-send-email-jh80.chung@samsung.com>
Date:   Thu, 14 Feb 2019 19:03:42 +0900
From:   Jaehoon Chung <jh80.chung@...sung.com>
To:     linux-usb@...r.kernel.org
Cc:     hminas@...opsys.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, m.szyprowski@...sung.com,
        Jaehoon Chung <jh80.chung@...sung.com>
Subject: [PATCH] usb: dwc2: hcd: call dwc2_is_controller_alive under
 spinlock

This patch is referred to Robert's patch
commit cf54772b913b ("usb: dwc2: call dwc2_is_controller_alive() under spinlock")

During running sdb with otg mode, the usb is hung sometime.

The one of SDB hang issues should be fixed with this patch.
After hang, it doesn't never trigger the usb interrupt.

Signed-off-by: Jaehoon Chung <jh80.chung@...sung.com>
---
 drivers/usb/dwc2/hcd_intr.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c
index 88b5dcf..8d3b155 100644
--- a/drivers/usb/dwc2/hcd_intr.c
+++ b/drivers/usb/dwc2/hcd_intr.c
@@ -2222,13 +2222,13 @@ irqreturn_t dwc2_handle_hcd_intr(struct dwc2_hsotg *hsotg)
 	u32 gintsts, dbg_gintsts;
 	irqreturn_t retval = IRQ_NONE;
 
+	spin_lock(&hsotg->lock);
+
 	if (!dwc2_is_controller_alive(hsotg)) {
 		dev_warn(hsotg->dev, "Controller is dead\n");
-		return retval;
+		goto out;
 	}
 
-	spin_lock(&hsotg->lock);
-
 	/* Check if HOST Mode */
 	if (dwc2_is_host_mode(hsotg)) {
 		gintsts = dwc2_read_core_intr(hsotg);
@@ -2276,6 +2276,7 @@ irqreturn_t dwc2_handle_hcd_intr(struct dwc2_hsotg *hsotg)
 		}
 	}
 
+out:
 	spin_unlock(&hsotg->lock);
 
 	return retval;
-- 
2.7.4