linux-kernel - Re: [PATCH 2/8] net: ethernet: stmmac: update to support all PHY config for stm32mp157c.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190214151540.GG708@lunn.ch>
Date:   Thu, 14 Feb 2019 16:15:40 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Christophe ROULLIER <christophe.roullier@...com>
Cc:     "robh@...nel.org" <robh@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Peppe CAVALLARO <peppe.cavallaro@...com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/8] net: ethernet: stmmac: update to support all PHY
 config for stm32mp157c.

> Sorry, I've misunderstood your question ;-)
> 
> And you spoke about :
> 
> case PHY_INTERFACE_MODE_RGMII:
> case PHY_INTERFACE_MODE_RGMII_ID:
> case PHY_INTERFACE_MODE_RGMII_RXID:
> case PHY_INTERFACE_MODE_RGMII_TXID:
> 
> So in my setup I've only RGMII interface, so I've never tested 3 others 
> interfaces (_ID, _RXID, _TXID).
> 
> So do I need to add cases in my driver ?

Yes. They all indicate the MAC should be using RGMII.

This appears to be an old issue, but now would be a good time to fix
it.

     Andrew