linux-kernel - Re: [PATCH] soc: qcom: rpmhpd: Set 'active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69c46e02-f6b7-c6b3-5dc1-8c9ecd88b14d@codeaurora.org>
Date:   Fri, 15 Feb 2019 08:02:40 +0530
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Douglas Anderson <dianders@...omium.org>,
        Andy Gross <andy.gross@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Stephen Boyd <swboyd@...omium.org>, linux-arm-msm@...r.kernel.org,
        David Brown <david.brown@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: rpmhpd: Set 'active_only' for active only
 power domains


On 2/14/2019 11:06 PM, Douglas Anderson wrote:
> The 'active_only' attribute was accidentally never set to true for any
> power domains meaning that all the code handling this attribute was
> dead.
> 
> NOTE that the RPM power domain code (as opposed to the RPMh one) gets
> this right.
> 
> Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Thanks for catching this. I seem to have introduced this bug when I moved
away from using the macros to define these static structs and failed to add
the property :/

Acked-by: Rajendra Nayak <rnayak@...eaurora.org>

> ---
> 
>   drivers/soc/qcom/rpmhpd.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index 5741ec3fa814..51850cc68b70 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -93,6 +93,7 @@ static struct rpmhpd sdm845_mx = {
>   
>   static struct rpmhpd sdm845_mx_ao = {
>   	.pd = { .name = "mx_ao", },
> +	.active_only = true,
>   	.peer = &sdm845_mx,
>   	.res_name = "mx.lvl",
>   };
> @@ -107,6 +108,7 @@ static struct rpmhpd sdm845_cx = {
>   
>   static struct rpmhpd sdm845_cx_ao = {
>   	.pd = { .name = "cx_ao", },
> +	.active_only = true,
>   	.peer = &sdm845_cx,
>   	.parent = &sdm845_mx_ao.pd,
>   	.res_name = "cx.lvl",
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation