lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Feb 2019 21:06:29 +0200 From: Kalle Valo <kvalo@...eaurora.org> To: Masahiro Yamada <yamada.masahiro@...ionext.com> Cc: Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>, "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org, linux-wireless@...r.kernel.org, Christoph Hellwig <hch@....de>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Lorenzo Bianconi <lorenzo.bianconi83@...il.com>, linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, Felix Fietkau <nbd@....name>, Matthias Brugger <matthias.bgg@...il.com> Subject: Re: [PATCH 1/2] wireless: mt76: call hweight8() instead of __sw_hweight8() Kalle Valo <kvalo@...eaurora.org> writes: > Masahiro Yamada <yamada.masahiro@...ionext.com> writes: > >> __sw_hweight8() is just internal implementation. >> >> Drivers should use the common API, hweight8(). >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com> > > Acked-by: Kalle Valo <kvalo@...eaurora.org> > >> This patch should go to x86 tree along with 2/2. >> >> Otherwise, all{yes,mod}config of x86 would be broken. >> >> This patch is trivial enough. >> I want ACK from the net/wireless maintainer >> so that this can go in via x86 tree. > > Sounds good to me, feel free to push via the x86 tree. Actually, can you wait a bit? Felix just reminded me that we have a similar patch pending from Ben Hutchings: https://patchwork.kernel.org/patch/10808203/ And it seems there are two instances of __sw_hweight8, at least in my wireless-drivers-next tree: drivers/net/wireless/mediatek/mt76/mac80211.c: int i, nstream = __sw_hweight8(dev->antenna_mask); drivers/net/wireless/mediatek/mt76/mac80211.c: int n_chains = __sw_hweight8(dev->antenna_mask); So we need to think what to do. -- Kalle Valo
Powered by blists - more mailing lists