lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 18 Feb 2019 21:06:29 +0200
From:   Kalle Valo <>
To:     Masahiro Yamada <>
Cc:     Ingo Molnar <>,
        Thomas Gleixner <>,
        Borislav Petkov <>,
        "H . Peter Anvin" <>,,, Christoph Hellwig <>,
        "David S. Miller" <>,,,
        Lorenzo Bianconi <>,,, Felix Fietkau <>,
        Matthias Brugger <>
Subject: Re: [PATCH 1/2] wireless: mt76: call hweight8() instead of __sw_hweight8()

Kalle Valo <> writes:

> Masahiro Yamada <> writes:
>> __sw_hweight8() is just internal implementation.
>> Drivers should use the common API, hweight8().
>> Signed-off-by: Masahiro Yamada <>
> Acked-by: Kalle Valo <>
>> This patch should go to x86 tree along with 2/2.
>> Otherwise, all{yes,mod}config of x86 would be broken.
>> This patch is trivial enough.
>> I want ACK from the net/wireless maintainer
>> so that this can go in via x86 tree.
> Sounds good to me, feel free to push via the x86 tree.

Actually, can you wait a bit? Felix just reminded me that we have a
similar patch pending from Ben Hutchings:

And it seems there are two instances of __sw_hweight8, at least in my
wireless-drivers-next tree:

drivers/net/wireless/mediatek/mt76/mac80211.c:  int i, nstream = __sw_hweight8(dev->antenna_mask);
drivers/net/wireless/mediatek/mt76/mac80211.c:  int n_chains = __sw_hweight8(dev->antenna_mask);

So we need to think what to do.

Kalle Valo

Powered by blists - more mailing lists